exclude msw from vite dep optimization to fix playwright tests #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playwright tests were failing, depending on which ones you run and on the number of Playwright workers. A consistent way to reproduce the problem was to run all tests with 3 Playwright workers. This caused the app e2e tests to fail beacuse of a 504 Outdated Optimize Dep response from node_modules/.vite/deps/msw.js. Excluding msw from the vite dep optimization seems to fix this issue. Note that using the --force flag or config option for vite dep optimization, might improve the situation, but didn't solve it.
praseodym
reviewed
Apr 24, 2024
|
lgtm, |
praseodym
previously approved these changes
Apr 24, 2024
|
more on the pipeline issue with installing playwright: actions/runner-images#9733 temp fix might be to change |
I assume this will be fixed soon, so let's just review this as if the pipeline ran successfully. If it's not fixed by the end of the day/tomorrow morning(?), this fix by a GitHub employee seems like the way to go. |
praseodym
approved these changes
Apr 24, 2024
|
issue with the Microsoft Ubuntu 22.04 repos was fixed! 🎉 |
Lionqueen94
approved these changes
Apr 25, 2024
lkleuver
pushed a commit
that referenced
this pull request
Apr 26, 2024
exclude msw from vite dep optimization Playwright tests were failing, depending on which ones you run and on the number of Playwright workers. A consistent way to reproduce the problem was to run all tests with 3 Playwright workers. This caused the app e2e tests to fail beacuse of a 504 Outdated Optimize Dep response from node_modules/.vite/deps/msw.js. Excluding msw from the vite dep optimization seems to fix this issue. Note that using the --force flag or config option for vite dep optimization, might improve the situation, but didn't solve it.
lkleuver
pushed a commit
that referenced
this pull request
Apr 29, 2024
exclude msw from vite dep optimization Playwright tests were failing, depending on which ones you run and on the number of Playwright workers. A consistent way to reproduce the problem was to run all tests with 3 Playwright workers. This caused the app e2e tests to fail beacuse of a 504 Outdated Optimize Dep response from node_modules/.vite/deps/msw.js. Excluding msw from the vite dep optimization seems to fix this issue. Note that using the --force flag or config option for vite dep optimization, might improve the situation, but didn't solve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
analysis and solution
Playwright tests were failing, depending on which ones you run and on the number of Playwright workers. A consistent way to reproduce the problem was to run all tests with 3 Playwright workers. This caused the app e2e tests to fail beacuse of a 504 Outdated Optimize Dep response from node_modules/.vite/deps/msw.js.
Excluding msw from the vite dep optimization seems to fix this issue. Note that using the --force flag or config option for vite dep optimization, might improve the situation, but didn't solve it.
closes #28
notes on testing
npm run e2e -- --workers 3consistently reproduced the issue, so that's a good start.npm run e2e -- --workers 8did not reproduce the issue on my machine, so it's a good idea to play around with the number of workers. Note that--workersalso accepts a percentage, e.g.--workers 50%(percentage of logical CPU cores).npm run e2eshould work, because that's the default way of running.Note that when running on GitHub Actions, number of workers is set to 100% through
playwright.config.ts, i.e. both of the available cores. Which explains why this issue has not been occurring in our pipeline.