-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement validation rules in backend #42
Conversation
And remove Hello World API endpoint.
And also lint tests using Clippy in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
one caveat. I worry that it might be hard to grasp the validation rules for non-coders.
I don't think we should have a goal of making code understandable for non-coders. The validation rules come from the controleprotocol which is published by the Kiesraad and very readable. Our code will be tested against these and other policies/laws ('wettelijke toets') by a third party, which should give non-coders enough confidence in our implementation without having to read the code themselves. |
Closes #26.
This implements the validation rules from #22 according to the API described in #25.
Also tested together with #31 and this did not break anything.