Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement validation rules in backend #42

Merged
merged 9 commits into from
May 17, 2024
Merged

Implement validation rules in backend #42

merged 9 commits into from
May 17, 2024

Conversation

praseodym
Copy link
Contributor

@praseodym praseodym commented May 16, 2024

Closes #26.

This implements the validation rules from #22 according to the API described in #25.

Also tested together with #31 and this did not break anything.

Copy link
Contributor

@lkleuver lkleuver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
one caveat. I worry that it might be hard to grasp the validation rules for non-coders.

@praseodym
Copy link
Contributor Author

one caveat. I worry that it might be hard to grasp the validation rules for non-coders.

I don't think we should have a goal of making code understandable for non-coders. The validation rules come from the controleprotocol which is published by the Kiesraad and very readable. Our code will be tested against these and other policies/laws ('wettelijke toets') by a third party, which should give non-coders enough confidence in our implementation without having to read the code themselves.

@praseodym praseodym enabled auto-merge (squash) May 17, 2024 12:19
@praseodym praseodym merged commit 2cd3165 into main May 17, 2024
2 checks passed
@praseodym praseodym deleted the validation branch May 17, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement validation in backend API
4 participants