Download at url with progress #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloading large files can be problematic because the
SMBClient.download(path: String)stores the whole file in memory, returning it as aDataobject.This PR adds a new
SMBClient.download(path: String, localPath: URL, overwrite: Bool, progressHandler: (Double) -> Void)to allow downloading files while writing the chunks of data to disk progressively, resulting in lower memory consumption.localPathaccepts a fileURL, following the existing API inSMBClient.upload(localPath: URL, remotePath path: String)overwriteflag enables overwriting the file if it already exists. If the file does exist and the flag is set tofalse, the download method throws aCocoaError.fileWriteFileExists(this is the best error I could find. let me know if there's a better one)progressHandlerallows for download progress updates. It follows the existing progressHandler API in the upload function.I've also added a test for the new method.