Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Use https for openarchives.org, kitodo.org and slub-dresden.de #1454

Merged
merged 3 commits into from
Feb 2, 2025
Merged

[MAINTENANCE] Use https for openarchives.org, kitodo.org and slub-dresden.de #1454

merged 3 commits into from
Feb 2, 2025
+28 −28

Conversation

stweil
Copy link
Member

@stweil stweil commented Feb 1, 2025

No description provided.

@stweil stweil changed the title Replace http by https for openarchives.org, kitodo.org and slub-dresden.de Use https for openarchives.org, kitodo.org and slub-dresden.de Feb 1, 2025
@sebastian-meyer sebastian-meyer added the 🛠 maintenance A task to keep the code up-to-date and manageable. label Feb 1, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (3e9b1d1) to head (e5bd504).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@     Coverage Diff      @@
##   main   #1454   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastian-meyer sebastian-meyer changed the title Use https for openarchives.org, kitodo.org and slub-dresden.de [MAINTENANCE] Use https for openarchives.org, kitodo.org and slub-dresden.de Feb 1, 2025
sebastian-meyer
sebastian-meyer requested changes Feb 1, 2025
View reviewed changes
Copy link
Member

@sebastian-meyer sebastian-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not change XML namespace URIs, especially those officially used in the OAI-PMH schema document.

Classes/Common/AbstractDocument.php Outdated Show resolved Hide resolved
Classes/Controller/OaiPmhController.php Outdated Show resolved Hide resolved
Documentation/Developers/Validation.rst Outdated Show resolved Hide resolved
Resources/Private/Templates/OaiPmh/Main.xml Outdated Show resolved Hide resolved
Resources/Private/Templates/OaiPmh/Main.xml Outdated Show resolved Hide resolved
Resources/Private/Templates/OaiPmh/Main.xml Outdated Show resolved Hide resolved
Resources/Private/Templates/OaiPmh/Main.xml Outdated Show resolved Hide resolved
Resources/Public/Stylesheets/OaiPmh.xsl Outdated Show resolved Hide resolved
Resources/Public/Stylesheets/OaiPmh.xsl Outdated Show resolved Hide resolved
Tests/Unit/Validation/DOMDocumentValidationStackTest.php Outdated Show resolved Hide resolved
@stweil
Use https for digital.slub-dresden.de
c69ce15 
Signed-off-by: Stefan Weil <sw@weilnetz.de>
@stweil stweil force-pushed the https branch 2 times, most recently from f34da4e to fcf99fa Compare February 1, 2025 22:10
stweil added 2 commits February 1, 2025 23:14
@stweil
Use https for kitodo.org
5753a64 
Signed-off-by: Stefan Weil <sw@weilnetz.de>
@stweil
Use https for www.openarchives.org (not for XML namespace)
e5bd504 
Don't use https for XML namespace.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@sebastian-meyer sebastian-meyer merged commit 94fbcce into kitodo:main Feb 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-meyer sebastian-meyer sebastian-meyer approved these changes

Assignees

@stweil stweil

Labels
🛠 maintenance A task to keep the code up-to-date and manageable.
Projects
None yet
Milestone
Kitodo.Presentation 6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stweil @sebastian-meyer