[MAINTENANCE] Allow PHP 8.4 and update dependencies #1455
Conversation
sebastian-meyer
added
the
🛠 maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1455 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. |
sebastian-meyer
changed the title
|
Hm, I don't like the big span of supported PHP versions, because we do not test all of them. Instead of making the support even wider, I am in favor of narrowing it down to those versions which are supported by both TYPO3 v11 and v12 (i. e. 8.1, 8.2 and 8.3). What do you think? |
|
Also, updating |
Signed-off-by: Stefan Weil <sw@weilnetz.de>
This fixes two vulnerabilities which were reported by Dependabot: - TYPO3 Scheduler Module vulnerable to Cross-Site Request Forgery (High) - TYPO3 Potential Open Redirect via Parsing Differences (Moderate) Signed-off-by: Stefan Weil <sw@weilnetz.de>
Both PHP releases had their end of life long ago. Signed-off-by: Stefan Weil <sw@weilnetz.de>
|
Dropping support for PHP 7.4 and PHP 8.0 is a good idea. |
Signed-off-by: Stefan Weil <sw@weilnetz.de>
It looks like exactly this CI test failure occurs from time to time, so it is unrelated to my modifications. |
This is done now. So two PHP releases were dropped, PHP 8.4 was added => the span of PHP releases decreased. The CI test with PHP 8.4 works locally and can be added here as soon as a pending issue is solved. |
|
Thanks for removing support for old PHP versions! It's much cleaner now! But I still don't think we should add support for PHP 8.4. I am in favor of sticking to those PHP versions which are supported by both TYPO3 versions, v11 and v12. (TYPO3 v11 doesn't support PHP 8.4.) It makes development and testing much easier. |
|
PHP 8.4 is the latest stable release and standard for me on my macBook. I recently switched to a native installation of Kitodo.Presentation there because it makes source code debugging much easier for me. But I can do this using my local fork, of course. |
| @@ -12,7 +12,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| variants: [ {typo3: 11.5, php: 7.4}, {typo3: 12.4, php: 8.1} ] | |||
| variants: [ {typo3: 11.5, php: 8.1}, {typo3: 12.4, php: 8.1}, {typo3: 12.4, php: 8.3} ] | |||
There was a problem hiding this comment.
Why not run tests for all supported combinations?
| variants: [ {typo3: 11.5, php: 8.1}, {typo3: 12.4, php: 8.1}, {typo3: 12.4, php: 8.3} ] | |
| variants: [ {typo3: 11.5, php: 8.1}, {typo3: 11.5, php: 8.2}, {typo3: 11.5, php: 8.3}, {typo3: 12.4, php: 8.1}, {typo3: 12.4, php: 8.2}, {typo3: 12.4, php: 8.3} ] |
| @@ -25,7 +25,7 @@ | |||
| "docs": "https://docs.typo3.org/p/kitodo/presentation/main/en-us/" | |||
| }, | |||
| "require": { | |||
| "php": "7.4 - 8.3", | |||
| "php": "8.1 - 8.4", | |||
There was a problem hiding this comment.
| "php": "8.1 - 8.4", | |
| "php": "8.1 - 8.3", |
| @@ -17,7 +17,7 @@ | |||
| 'category' => 'misc', | |||
| 'constraints' => [ | |||
| 'depends' => [ | |||
| 'php' => '7.4.0-8.3.99', | |||
| 'php' => '7.4.0-8.4.99', | |||
There was a problem hiding this comment.
| 'php' => '7.4.0-8.4.99', | |
| 'php' => '8.1.0-8.3.99', |
There was a problem hiding this comment.
Please re-run composer update with PHP 8.1.
This fixes two vulnerabilities which were reported by Dependabot.