Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3.0 Update #23

Merged
merged 23 commits into from
Apr 22, 2024
Merged

2.3.0 Update #23

merged 23 commits into from
Apr 22, 2024

Conversation

kmnhan
Copy link
Owner

@kmnhan kmnhan commented Apr 16, 2024

  • Add new interface for fitting, see A better fitting interface #22 for discussions
  • Tweaks to io
    • Make loader argument optional for loader_context so it can be used to just change the data directory
  • Better momentum conversion
    • Try to discern Kinetic or Binding
    • Rewrite with apply_ufunc, make dask-compatible

This improves performance and results when eV is large like ~100eV.
@kmnhan kmnhan self-assigned this Apr 16, 2024
@kmnhan kmnhan marked this pull request as ready for review April 16, 2024 10:14
@kmnhan kmnhan marked this pull request as draft April 16, 2024 10:14
kmnhan and others added 5 commits April 18, 2024 18:10
Allow images including nan to be plotted with gen_2d_colormap, also handle plot_array_2d colorbar aspect
Calling from utilities will now raise a DeprecationWarning.
The erlab.analysis namespace is unchanged, so the affect will be minimal.
Add a `Dataset.modelfit` and `DataArray.modelfit` accessor with similar syntax and output as `Dataset.curvefit`. Closes #22
@kmnhan kmnhan linked an issue Apr 20, 2024 that may be closed by this pull request
@kmnhan kmnhan force-pushed the dev branch 2 times, most recently from 08a3760 to cae63c0 Compare April 21, 2024 08:35
kmnhan added 5 commits April 21, 2024 18:06
Tqdm imports are also simplified. We no longer handle `is_notebook` ourselves, but just import from `tqdm.auto`
Also add sample data generation for fermi edge
Updated requirements, contrib page, fitting guide.
Source button now links to github.
Allows dictionary of `DataArray`s as parameter to fit accessor.
Now, the return `Dataset` contains the data and the best fit array. Relevant tests have been added.
@kmnhan kmnhan force-pushed the dev branch 2 times, most recently from cf2235b to 93ad523 Compare April 21, 2024 15:54
kmnhan added 5 commits April 22, 2024 09:53
Momentum conversion now relies on xarray broadcasting for all computations, and objects with extra dimensions such as temperature can be automatically broadcasted.
Dask arrays can also be converted.
@kmnhan kmnhan marked this pull request as ready for review April 22, 2024 13:45
@kmnhan kmnhan merged commit 4514a23 into main Apr 22, 2024
6 checks passed
@kmnhan kmnhan deleted the dev branch April 22, 2024 14:14
@kmnhan kmnhan added documentation enhancement New feature or request labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A better fitting interface
1 participant