Errors when deploying newest version of Knative CRDs #5759
Comments
|
@gunpuz: GitHub didn't allow me to assign the following users: user. Note that only knative members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
gunpuz
changed the title
|
I just deployed on a GKE cluster without issue. Tell me more about your setup |
|
What info would be usefull? |
|
What version of kubernetes? Where is it hosted (MiniKube, GKE, EKS, etc.)? What else is installed on the cluster (specifically at the time of deploying knative) |
|
Its hosted on Ubuntu: There are already some custom services, helm charts... , including Knative Serving, Knative Eventing |
|
v1alpha1 version of DomainMapping was deprecated in 1.11, see https://github.com/knative/serving/releases/tag/knative-v1.11.0. It looks like you were still using them when migrating to version 1.12 which will cause the error. Make sure you update your DomainMapping objects to the new version before installing 1.12. |
|
What is the recommended upgrade procedure? Is there any docs for this? You could give some hint, please :) |
|
I would assume just updating the domainmapping yamls to reflect the new API https://knative.dev/docs/serving/services/custom-domains/#procedure |
|
So serving has a post install job after upgrading that needs to run eg. https://github.com/knative/serving/releases/download/knative-v1.12.1/serving-post-install-jobs.yaml This typically will set things up for the next release. If you run that job now prior to upgrading you should be fine. We sorta mention it in the link below but I think we could do a better job documenting it https://knative.dev/docs/install/yaml-install/serving/serving-installation-files/ |
|
/assign I'll add a bit more to the update docs. @gunpuz this job will migrate the existing objects on the cluster, but you still need to update the version in your own instances of |
|
Unfortunately the Uninstalling just Knative Serving and installing it again solved this issue. P.S. @ReToCode kubectl create -f https://github.com/knative/serving/releases/download/knative-v1.12.2/serving-post-install-jobs.yamlinstead of kubectl apply -f https://github.com/knative/serving/releases/download/knative-v1.12.2/serving-post-install-jobs.yaml |
|
@ReToCode so should we reopen this issue then? For example: Step 1: Add older Knativekubectl apply -f https://github.com/knative/serving/releases/download/knative-v1.10.2/serving-crds.yaml
kubectl wait --for=condition=Established --all crd
kubectl apply -f https://github.com/knative/serving/releases/download/knative-v1.10.2/serving-core.yaml
kubectl apply -f https://github.com/knative/net-kourier/releases/download/knative-v1.10.0/kourier.yaml
#kubectl patch configmap/config-network --namespace knative-serving --type merge --patch '{"data":{"ingress-class":"kourier.ingress.networking.knative.dev"}}'
# Adjustment for PowerShell
kubectl patch configmap/config-network --namespace knative-serving --type merge --patch '{\"data\":{\"ingress-class\":\"kourier.ingress.networking.knative.dev\"}}'
# Wait for Knative to become ready before starting knative services
kubectl wait --for=condition=ready --timeout=60s -n knative-serving --all pods
kubectl wait --for=condition=ready --timeout=60s -n kourier-system --all podsStep 2: Update to newer Knativekubectl apply -f https://github.com/knative/serving/releases/download/knative-v1.12.2/serving-crds.yaml
kubectl wait --for=condition=Established --all crd
kubectl apply -f https://github.com/knative/serving/releases/download/knative-v1.12.2/serving-core.yaml
kubectl apply -f https://github.com/knative/net-kourier/releases/download/knative-v1.12.1/kourier.yamlCheck if error is reported:
Step 3: Run post install jobkubectl create -f https://github.com/knative/serving/releases/download/knative-v1.12.2/serving-post-install-jobs.yaml
Step 4: Check this migration job logs to see anything interesting{"severity":"INFO","timestamp":"2023-12-05T09:09:30.6460017Z","caller":"logging/config.go:80","message":"Unable to read vcs.revision from binary"}
{"severity":"INFO","timestamp":"2023-12-05T09:09:30.6467751Z","logger":"storage-migrator","caller":"migrate/main.go:69","message":"Migrating 5 group resources"}
{"severity":"INFO","timestamp":"2023-12-05T09:09:30.6468262Z","logger":"storage-migrator","caller":"migrate/main.go:72","message":"Migrating group resource services.serving.knative.dev"}
{"severity":"INFO","timestamp":"2023-12-05T09:09:30.6593467Z","logger":"storage-migrator","caller":"migrate/main.go:72","message":"Migrating group resource configurations.serving.knative.dev"}
{"severity":"INFO","timestamp":"2023-12-05T09:09:30.666545Z","logger":"storage-migrator","caller":"migrate/main.go:72","message":"Migrating group resource revisions.serving.knative.dev"}
{"severity":"INFO","timestamp":"2023-12-05T09:09:30.6756363Z","logger":"storage-migrator","caller":"migrate/main.go:72","message":"Migrating group resource routes.serving.knative.dev"}
{"severity":"INFO","timestamp":"2023-12-05T09:09:30.6784452Z","logger":"storage-migrator","caller":"migrate/main.go:72","message":"Migrating group resource domainmappings.serving.knative.dev"}
{"severity":"INFO","timestamp":"2023-12-05T09:09:30.6817267Z","logger":"storage-migrator","caller":"migrate/main.go:82","message":"Migration complete"}Only thing that is "unusual" is - Step 5: Run step 2 to check if error got away |
|
Hm you can not update from 1.10 to 1.12 (see https://knative.dev/docs/install/upgrade/). Does the same thing occur when you do it 1.10 -> 1.11 -> 1.12? |
|
This should could be the cause then if minor versions cannot be skipped. |
Expected Behavior
Knative CRDS would deploy without STDERRs
Actual Behavior
Standart error is reported about incorrect CRD:
Steps to Reproduce the Problem
kubectl apply -f https://github.com/knative/serving/releases/download/knative-v1.12.0/serving-crds.yamlAdditional Info
The text was updated successfully, but these errors were encountered: