Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the update documentation for CRD version changes #5769

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

ReToCode
Copy link
Member

Proposed Changes

  • Extend the description on how to update with kubectl with regards to CRD storage version changes

Fixes #5759

/assign @dprotaso

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit edfa158
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65605a26be881f0008cc811e
😎 Deploy Preview https://deploy-preview-5769--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

knative-prow bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 24, 2023
@ReToCode ReToCode changed the title Extend the update documentation for CRD changes Extend the update documentation for CRD version changes Nov 24, 2023
@ReToCode
Copy link
Member Author

/cherry-pick release-1.12

@knative-prow-robot
Copy link
Contributor

@ReToCode: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode
Copy link
Member Author

/assign @nak3
/assign @skonto

@nak3
Copy link
Contributor

nak3 commented Nov 30, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@knative-prow knative-prow bot merged commit 9de54de into knative:main Nov 30, 2023
@knative-prow-robot
Copy link
Contributor

@ReToCode: new pull request created: #5781

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors when deploying newest version of Knative CRDs
5 participants