Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop net-http01 from v1.13 release #5761

Merged
merged 1 commit into from
Nov 22, 2023
Merged

drop net-http01 from v1.13 release #5761

merged 1 commit into from
Nov 22, 2023

Conversation

dprotaso
Copy link
Member

@knative-prow knative-prow bot requested review from csantanapr and nak3 November 20, 2023 22:12
@netlify Netlify
Copy link

netlify bot commented Nov 20, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Name Link
🔨 Latest commit cfdcd9c
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/655bd9cdc233b70009fa9a1a
😎 Deploy Preview https://deploy-preview-5761--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2023
@dprotaso dprotaso mentioned this pull request Nov 20, 2023
Closed
14 tasks
@dprotaso
Copy link
Member Author

We technically want to merge the release branches first

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2023
@dprotaso
Copy link
Member Author

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2023
ReToCode
ReToCode approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 826b7eb into knative:main Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@csantanapr csantanapr Awaiting requested review from csantanapr

@nak3 nak3 Awaiting requested review from nak3

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dprotaso @ReToCode