Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable copy for code blocks #5806

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Jan 4, 2024

Context: https://cloud-native.slack.com/archives/C04LY5G9ED7/p1704358780773299

Proposed Changes

  • Enables copy buttons on code (shell) blocks

/assign @skonto

Copy link

knative-prow bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from nak3 and pmbanugo January 4, 2024 09:13
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2024
Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a81fb02
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/659676b1eca16f0008ef6a3d
😎 Deploy Preview https://deploy-preview-5806--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 4, 2024
@ReToCode
Copy link
Member Author

ReToCode commented Jan 4, 2024

/cherry-pick release-1.12

@knative-prow-robot
Copy link
Contributor

@ReToCode: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skonto
Copy link
Contributor

skonto commented Jan 4, 2024

Out of curiosity do we want to have this button everywhere or just with bash commands (starting with ```bash)? Right now it is everywhere. Does not hurt imho (checked other projects eg. Istio which have the same). WDYTH?

@skonto
Copy link
Contributor

skonto commented Jan 4, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2024
@knative-prow knative-prow bot merged commit ea6308e into knative:main Jan 4, 2024
19 checks passed
@knative-prow-robot
Copy link
Contributor

@ReToCode: new pull request created: #5808

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode
Copy link
Member Author

ReToCode commented Jan 4, 2024

Out of curiosity do we want to have this button everywhere or just with bash commands (starting with ```bash)? Right now it is everywhere. Does not hurt imho (checked other projects eg. Istio which have the same). WDYTH?

I think it would be sufficient for bash, but seems this is the way mkdocs works. Not sure if we could tweak every place we have a code block somehow.

prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants