Update docs for Eventing TLS Beta #5967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
do-not-merge/work-in-progress
knative-prow
bot
added
the
size/L
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
pierDipi
force-pushed
the
transport-encryption-beta-docs
branch
3 times, most recently
from
8875b7b to
7919e4e
Compare
pierDipi
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
Cali0707
reviewed
May 13, 2024
Comment on lines
159
to
161
| !!! important | ||
| The `strict` is only enforced on the Broker and Channel receiver/ingress. Senders can still send | ||
| events over plaintext HTTP. |
There was a problem hiding this comment.
@pierDipi could we reword this? I find it a little confusing. To me, Senders can still send events over plaintext HTTP sounds like I can still send my events over http to a broker. But, my understanding is that we are trying to say that when a broker or channel sends events to a subscriber, if that subscriber only has a HTTP address, the broker or channel will send the event with HTTP instead of HTTPS.
Comment on lines
176
to
182
| ## Configure additional CA trust bundles | ||
|
|
||
| By default, Eventing clients trusts the system root CA (public CA). | ||
|
|
||
| If you need to add additional CA bundles for Eventing, you can do so by creating ConfigMaps in the | ||
| `knative-eventing` namespace with label `networking.knative.dev/trust-bundle: true`: |
There was a problem hiding this comment.
Maybe we can mention trust-manager here as a good way to do this?
| @@ -208,7 +208,7 @@ Alternatively, if you are using a GitOps approach, you can add the `consumers` k | |||
|
|
|||
| ### Automatic Scaling with KEDA | |||
|
|
|||
| Kafka Sources have experimental (Alpha) support for serverless scaling with KEDA, including scale to zero. If you want Knative and KEDA to scale your Kafka source for you, | |||
| Kafka Sources have (Alpha) support for serverless scaling with KEDA, including scale to zero. If you want Knative and KEDA to scale your Kafka source for you, | |||
There was a problem hiding this comment.
Suggested change
| Kafka Sources have (Alpha) support for serverless scaling with KEDA, including scale to zero. If you want Knative and KEDA to scale your Kafka source for you, | |
| Kafka Sources and Brokers have (Alpha) support for serverless scaling with KEDA, including scale to zero. If you want Knative and KEDA to scale your Kafka source for you, |
knative-prow-robot
added
the
needs-rebase
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
transport-encryption-beta-docs
branch
from
7919e4e to
0499d92
Compare
knative-prow-robot
removed
the
needs-rebase
|
@Cali0707 thanks, see latest commits! |
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes