Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the removed redirects #5971

Merged
merged 1 commit into from
May 15, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented May 14, 2024

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

@skonto skonto requested a review from dprotaso May 14, 2024 15:08
@knative-prow knative-prow bot requested review from nainaz and snneji May 14, 2024 15:08
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 14, 2024
@skonto skonto changed the title Revert removed redirects Bring back the removed redirects May 14, 2024
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@skonto skonto removed request for snneji and nainaz May 14, 2024 15:08
Copy link

netlify bot commented May 14, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 843fa1a
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/66437e5c3fe07c0008dc990e
😎 Deploy Preview https://deploy-preview-5971--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
Copy link

knative-prow bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 0b9af69 into knative:main May 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants