Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a Blog Post Detailing My LFX Mentorship Project #6001

Merged
merged 4 commits into from
May 30, 2024
Merged

Added a Blog Post Detailing My LFX Mentorship Project #6001

merged 4 commits into from
May 30, 2024

Conversation

prajjwalyd
Copy link
Contributor

@prajjwalyd prajjwalyd commented May 30, 2024 •
edited
Loading

Proposed Changes

@knative-prow knative-prow bot requested review from csantanapr and ReToCode May 30, 2024 14:36
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 30, 2024
@netlify Netlify
Copy link

netlify bot commented May 30, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dbdfa32
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6658ea2ac8dd86000825359d
😎 Deploy Preview https://deploy-preview-6001--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Cali0707
Copy link
Member

/assign

@prajjwalyd prajjwalyd changed the title Added a Blog Post Detailing My LFX Mentorship Experience Added a Blog Post Detailing My LFX Mentorship Project May 30, 2024
Cali0707
Cali0707 suggested changes May 30, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes then this is LGTM from my side

/cc @Leo6Leo

blog/docs/articles/enhancing-the-knative-experience.md Outdated Show resolved Hide resolved
blog/docs/index.md Outdated Show resolved Hide resolved
@knative-prow knative-prow bot requested a review from Leo6Leo May 30, 2024 20:11
@prajjwalyd prajjwalyd requested a review from Leo6Leo May 30, 2024 21:07
Cali0707
Cali0707 approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, prajjwalyd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@knative-prow knative-prow bot merged commit ba5d2ff into knative:main May 30, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@csantanapr csantanapr Awaiting requested review from csantanapr

@ReToCode ReToCode Awaiting requested review from ReToCode

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@Leo6Leo Leo6Leo

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prajjwalyd @Cali0707 @Leo6Leo