Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix footer styling issue #6004

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

rohitsrma
Copy link
Contributor

Currently, in the footer of our website's documentation section, the 'Next' and 'Previous' links are shown in front of the page's title, and they have different font sizes. I'm sure this wasn't done on purpose. The problem is because the title and the navigation links are in the same class, which messes up the styles.

To fix this, I moved the footer text outside of that class. This way, the existing styles won't get overridden by the class styles.

Before

image

After

image

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2024
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0d51a46
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/665e29126f19cc0008e233c4
😎 Deploy Preview https://deploy-preview-6004--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Cali0707
Copy link
Member

Cali0707 commented Jun 3, 2024

/cc @zainabhusain227 @mmejia02

@knative-prow knative-prow bot requested a review from mmejia02 June 3, 2024 21:23
Copy link

github-actions bot commented Sep 2, 2024

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2024
@Cali0707
Copy link
Member

Cali0707 commented Sep 2, 2024

/remove-lifecycle stale

Adding this PR to the next UX WG meeting agenda for review

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2024
@Cali0707
Copy link
Member

Cali0707 commented Sep 5, 2024

Moving this to the next UX meeting time

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
Copy link

knative-prow bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, rohitsrma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2024
@knative-prow knative-prow bot merged commit 2850710 into knative:main Sep 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants