-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample App Tutorial Page Compilation #6007
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks Leo, this is great! |
I can create a tread and ask how UX WG think, and whether designers have some ideas on it! |
@Leo6Leo instead of adding another tab to the top level navigation (which is already too full according to the UX group), can we put the bookstore tutorial under the already existing Tutorial tab? Maybe we can have a start page there that opens to either the quickstart tutorial or the e2e bookstore tutorial? |
Yeah I do agree, the current top level navigation is really packed. And a start page idea sounds good to me! I will reflect the changes in this PR. |
How's about adding it in sidebar of getting-started-page ? And adding a button in home page which can will take users directly to tutorial page, just like it is there in NextJs home page
|
Yes, I agree with @Cali0707. Current nav bar already been tightly packed :) Hopefully we have new design getting it narrow down. |
Something from the user perspective, a user(this can be me) can be curious to see what's newly added to the Knative. For an instance, we have introduced this Bookstore tutorial or new releases or new events etc.. It can make a quick access and overview of the what's the latest news of Knative. Can we add any section of What's new? If yes, we can add this beside Needs to Know more, something it seems like we are using more space here :) cc: @knative/ux-wg-leads |
Hey @asr2003 that's a neat idea, but I don't think this is the best spot to discuss that. Normally on PRs we just discuss the changes involved in this PR, not ideas for other changes. I would recommend opening an issue in the UX repository or starting a new thread on slack |
Just got this idea while exploring this PR, so i have dropped my idea here without further missing any from my mind :) Okay, we can continue this in our existing thread in ux channel |
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
docs/bookstore/page-2/sentiment-analysis-service-for-bookstore-reviews.md
Show resolved
Hide resolved
Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@matzew is this PR something you can take a look at? |
|
||
![Image](images/image13.png) | ||
|
||
Please follow the instructions [here](https://knative.dev/docs/install/){:target="_blank"} to spin up your cluster with Knative installed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we mention we do recommend kn quickstart
?
|
||
**Create a SinkBinding:** | ||
|
||
- 1: Create a new YAML file named `300-sinkbinding.yaml` in the `node-server/config` folder and add the following content: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use the full path (node-server/config/300-sinkbinding.yaml
), yes that is repaetive but much nice for copy paste.
|
||
**Create an Event Display Service:** | ||
|
||
- 1: Create a new YAML file named `100-event-display.yaml` in the `node-server/config` folder and add the following content: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same. not copy-pasta friendly :-)
In this case, we are creating a Python function, so the command will be: | ||
|
||
``` | ||
func create -l python sentiment-analysis-app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some ppint we need to update this.
We are currently rewriting the py middleware, and will likely create also a few new templates.
But that is second half of 2024 - hopefully /cc @lkingland
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue created to keep track this. #6044
|
||
In order to properly use the `textblob` library, you need to download the corpora, which is a large collection of text data that is used to train the sentiment analysis model. You can do this by creating a new file called `setup.py`, Knative Function will ensure that the `setup.py` file is executed after the dependencies have been installed. | ||
|
||
The `setup.py` file should contain the following code for your bookstore: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this is all really needed.
I think the tutorial is already complex, as it covers a lot of things.
For folks have no idea on python, I guess they are all lost .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to use textblob library, we have to download their corpora file before hand. Unless there are any other methods we can do that, I think the setup.py
part tutorial is necessary, and this approach is not documented anywhere in Knative's website. WDYT? @matzew
After you have finished the code, you can deploy the function to the cluster using the following command: | ||
|
||
```bash | ||
func deploy -b=s2i -v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
➜ sentiment-analysis-app git:(10b0ae6) ✗ func deploy
function up-to-date. Force rebuild with --build
Pushing function image to the registry "index.docker.io" using the "matzew" user credentials
⬆️ Deploying function to the cluster
^C
Service output:
Traceback (most recent call last):
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/main.py", line 29, in
main()
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/main.py", line 20, in main
app = server.create(server.load(sys.argv[1]))
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/server.py", line 16, in load
import func
File "/workspace/func.py", line 4, in
from textblob import TextBlob
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/textblob/init.py", line 1, in
from .blob import Blobber, Sentence, TextBlob, Word, WordList
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/textblob/blob.py", line 26, in
import nltk
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/init.py", line 153, in
from nltk.translate import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/translate/init.py", line 24, in
from nltk.translate.meteor_score import meteor_score as meteor
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/translate/meteor_score.py", line 13, in
from nltk.corpus import WordNetCorpusReader, wordnet
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/init.py", line 64, in
from nltk.corpus.reader import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/reader/init.py", line 106, in
from nltk.corpus.reader.panlex_lite import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/reader/panlex_lite.py", line 15, in
import sqlite3
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/sqlite3/init.py", line 57, in
from sqlite3.dbapi2 import *
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/sqlite3/dbapi2.py", line 27, in
from _sqlite3 import *
ImportError: libsqlite3.so.0: cannot open shared object file: No such file or directory
Traceback (most recent call last):
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/main.py", line 29, in
main()
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/main.py", line 20, in main
app = server.create(server.load(sys.argv[1]))
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/server.py", line 16, in load
import func
File "/workspace/func.py", line 4, in
from textblob import TextBlob
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/textblob/init.py", line 1, in
from .blob import Blobber, Sentence, TextBlob, Word, WordList
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/textblob/blob.py", line 26, in
import nltk
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/init.py", line 153, in
from nltk.translate import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/translate/init.py", line 24, in
from nltk.translate.meteor_score import meteor_score as meteor
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/translate/meteor_score.py", line 13, in
from nltk.corpus import WordNetCorpusReader, wordnet
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/init.py", line 64, in
from nltk.corpus.reader import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/reader/init.py", line 106, in
from nltk.corpus.reader.panlex_lite import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/reader/panlex_lite.py", line 15, in
import sqlite3
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/sqlite3/init.py", line 57, in
from sqlite3.dbapi2 import *
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/sqlite3/dbapi2.py", line 27, in
from _sqlite3 import *
ImportError: libsqlite3.so.0: cannot open shared object file: No such file or directory
Traceback (most recent call last):
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/main.py", line 29, in
main()
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/main.py", line 20, in main
app = server.create(server.load(sys.argv[1]))
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/server.py", line 16, in load
import func
File "/workspace/func.py", line 4, in
from textblob import TextBlob
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/textblob/init.py", line 1, in
from .blob import Blobber, Sentence, TextBlob, Word, WordList
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/textblob/blob.py", line 26, in
import nltk
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/init.py", line 153, in
from nltk.translate import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/translate/init.py", line 24, in
from nltk.translate.meteor_score import meteor_score as meteor
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/translate/meteor_score.py", line 13, in
from nltk.corpus import WordNetCorpusReader, wordnet
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/init.py", line 64, in
from nltk.corpus.reader import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/reader/init.py", line 106, in
from nltk.corpus.reader.panlex_lite import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/reader/panlex_lite.py", line 15, in
import sqlite3
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/sqlite3/init.py", line 57, in
from sqlite3.dbapi2 import *
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/sqlite3/dbapi2.py", line 27, in
from _sqlite3 import *
ImportError: libsqlite3.so.0: cannot open shared object file: No such file or directory
Traceback (most recent call last):
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/main.py", line 29, in
main()
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/main.py", line 20, in main
app = server.create(server.load(sys.argv[1]))
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/server.py", line 16, in load
import func
File "/workspace/func.py", line 4, in
from textblob import TextBlob
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/textblob/init.py", line 1, in
from .blob import Blobber, Sentence, TextBlob, Word, WordList
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/textblob/blob.py", line 26, in
import nltk
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/init.py", line 153, in
from nltk.translate import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/translate/init.py", line 24, in
from nltk.translate.meteor_score import meteor_score as meteor
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/translate/meteor_score.py", line 13, in
from nltk.corpus import WordNetCorpusReader, wordnet
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/init.py", line 64, in
from nltk.corpus.reader import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/reader/init.py", line 106, in
from nltk.corpus.reader.panlex_lite import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/reader/panlex_lite.py", line 15, in
import sqlite3
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/sqlite3/init.py", line 57, in
from sqlite3.dbapi2 import *
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/sqlite3/dbapi2.py", line 27, in
from _sqlite3 import *
ImportError: libsqlite3.so.0: cannot open shared object file: No such file or directory
Traceback (most recent call last):
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/main.py", line 29, in
main()
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/main.py", line 20, in main
app = server.create(server.load(sys.argv[1]))
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/server.py", line 16, in load
import func
File "/workspace/func.py", line 4, in
from textblob import TextBlob
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/textblob/init.py", line 1, in
from .blob import Blobber, Sentence, TextBlob, Word, WordList
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/textblob/blob.py", line 26, in
import nltk
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/init.py", line 153, in
from nltk.translate import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/translate/init.py", line 24, in
from nltk.translate.meteor_score import meteor_score as meteor
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/translate/meteor_score.py", line 13, in
from nltk.corpus import WordNetCorpusReader, wordnet
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/init.py", line 64, in
from nltk.corpus.reader import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/reader/init.py", line 106, in
from nltk.corpus.reader.panlex_lite import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/reader/panlex_lite.py", line 15, in
import sqlite3
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/sqlite3/init.py", line 57, in
from sqlite3.dbapi2 import *
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/sqlite3/dbapi2.py", line 27, in
from _sqlite3 import *
ImportError: libsqlite3.so.0: cannot open shared object file: No such file or directory
Traceback (most recent call last):
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/main.py", line 29, in
main()
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/main.py", line 20, in main
app = server.create(server.load(sys.argv[1]))
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/server.py", line 16, in load
import func
File "/workspace/func.py", line 4, in
from textblob import TextBlob
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/textblob/init.py", line 1, in
from .blob import Blobber, Sentence, TextBlob, Word, WordList
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/textblob/blob.py", line 26, in
import nltk
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/init.py", line 153, in
from nltk.translate import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/translate/init.py", line 24, in
from nltk.translate.meteor_score import meteor_score as meteor
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/translate/meteor_score.py", line 13, in
from nltk.corpus import WordNetCorpusReader, wordnet
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/init.py", line 64, in
from nltk.corpus.reader import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/reader/init.py", line 106, in
from nltk.corpus.reader.panlex_lite import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/reader/panlex_lite.py", line 15, in
import sqlite3
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/sqlite3/init.py", line 57, in
from sqlite3.dbapi2 import *
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/sqlite3/dbapi2.py", line 27, in
from _sqlite3 import *
ImportError: libsqlite3.so.0: cannot open shared object file: No such file or directory
Traceback (most recent call last):
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/main.py", line 29, in
main()
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/main.py", line 20, in main
app = server.create(server.load(sys.argv[1]))
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/parliament/server.py", line 16, in load
import func
File "/workspace/func.py", line 4, in
from textblob import TextBlob
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/textblob/init.py", line 1, in
from .blob import Blobber, Sentence, TextBlob, Word, WordList
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/textblob/blob.py", line 26, in
import nltk
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/init.py", line 153, in
from nltk.translate import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/translate/init.py", line 24, in
from nltk.translate.meteor_score import meteor_score as meteor
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/translate/meteor_score.py", line 13, in
from nltk.corpus import WordNetCorpusReader, wordnet
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/init.py", line 64, in
from nltk.corpus.reader import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/reader/init.py", line 106, in
from nltk.corpus.reader.panlex_lite import *
File "/layers/paketo-buildpacks_pip-install/packages/lib/python3.10/site-packages/nltk/corpus/reader/panlex_lite.py", line 15, in
import sqlite3
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/sqlite3/init.py", line 57, in
from sqlite3.dbapi2 import *
File "/layers/paketo-buildpacks_cpython/cpython/lib/python3.10/sqlite3/dbapi2.py", line 27, in
from _sqlite3 import *
ImportError: libsqlite3.so.0: cannot open shared object file: No such file or directory
deploy error: knative deployer failed to wait for the Knative Service to become ready: context canceled
Error: knative deployer failed to wait for the Knative Service to become ready: context canceled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please say that s2i
is required and the default pack
does NOT work
|
||
The `setup.py` file should contain the following code for your bookstore: | ||
|
||
???+ abstract "_sentiment-analysis-app/setup.py_" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just include? no other steps like referencing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No! Just Include the setup.py
file, then all good!
|
||
--- | ||
|
||
### **Step 1: Create a Knative Function template** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I miss instructions here to copy paste the commands for that "create"
|
||
## **Implementation** | ||
|
||
### **Step 0: Learn Sequence** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to use the sequence for this. Is a good fit here!
Spot on!
In this section, we will just be simply running a PostgreSQL service. We have all config files ready. Simply run the following command to apply all yamls at once. | ||
|
||
```sh | ||
kubectl apply -f db-service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'd list each file, and have one / two sentences on what that is .
This DB is option, but just applying a bag of yaml is not always helpful :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on the opposite opinion as it's not the point of the tutorial to explain how to deploy a database on Kubernetes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't explain it in here, but we have the detailed explanation in the db-service README.md
|
||
![image2](images/image2.png) | ||
|
||
???+ bug "Troubleshoot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this box up - I was stuck here too, and afterwards read the hint :-)
job.batch/postgresql-job created | ||
``` | ||
|
||
Wait a moment until all the pods become available and the database migration job is completed. If you see some job pods are failing and **having errors, don't worry**, please wait until at least one job becomes "**Completed**". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd highlight this a bit
A nice, and lengthly tutorial This is something that we could use for like 3 hiur workshops at conferences. Very nice ! |
LGTM I am not sure if some of @pierDipi's comments need to be addressed as well - mine are cosmetics, and I added hints what I found sub-optimal, feel free to polish this in a different PR |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leo6Leo, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
/cherry-pick release-1.14 |
@matzew: #6007 failed to apply on top of branch "release-1.14":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ok, than not :-) |
fixes #5938
Proposed Changes