Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new post on S3 events to Knative Functions #6014

Merged
merged 7 commits into from
Jun 14, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Jun 13, 2024

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2024
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 13, 2024
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5e770b7
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/666bf9432429a20008c1ed0c
😎 Deploy Preview https://deploy-preview-6014--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the blog post! I left a couple wording changes but otherwise I think this is really cool!

blog/docs/articles/consuming_s3_data_with_knative.md Outdated Show resolved Hide resolved
blog/docs/articles/consuming_s3_data_with_knative.md Outdated Show resolved Hide resolved
blog/docs/articles/consuming_s3_data_with_knative.md Outdated Show resolved Hide resolved
blog/docs/articles/consuming_s3_data_with_knative.md Outdated Show resolved Hide resolved
blog/docs/articles/consuming_s3_data_with_knative.md Outdated Show resolved Hide resolved
blog/docs/articles/consuming_s3_data_with_knative.md Outdated Show resolved Hide resolved
matzew and others added 6 commits June 14, 2024 09:47
Co-authored-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew changed the title WIP: Adding a new post on S3 events to Knative Functions Adding a new post on S3 events to Knative Functions Jun 14, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2024
@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
Copy link

knative-prow bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@knative-prow knative-prow bot merged commit 3631ec4 into knative:main Jun 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants