Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post update: Adding a little CE / S3 mapping hint #6025

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Jun 25, 2024

Proposed Changes

  • Improving blog post, by adding a bit of context on what the CE attrs mean

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2024
Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for knative failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 60ac5fe
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/667a6326a53b4d0008fafbfe

@knative-prow knative-prow bot requested review from Cali0707 and nainaz June 25, 2024 05:50
@matzew matzew force-pushed the update_lambda_migration_blog branch from 0bbe01d to 7b28853 Compare June 25, 2024 05:52
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the update_lambda_migration_blog branch from 7b28853 to 60ac5fe Compare June 25, 2024 06:26

!!! note

The CNCF CloudEvents specification allows a generic and independent approach for receiving events from 3rd party systems, while providing a common, standardized API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth to add link to spec here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we link to the project already in the document. and the AWS bits are not really spec'ed out. Apache Camel K was using "common sense" for the mapping 😅

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2024
Copy link

knative-prow bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2024
@knative-prow knative-prow bot merged commit ac4af72 into knative:main Jun 25, 2024
15 of 19 checks passed
dsimansk added a commit to dsimansk/docs that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants