-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap website colours of the Home page #6029
Conversation
Signed-off-by: SHRAVANI KAWARE <97099574+ShravaniAK@users.noreply.github.com>
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/hold until UX WG approves colour changes |
Signed-off-by: SHRAVANI KAWARE <97099574+ShravaniAK@users.noreply.github.com>
@ShravaniAK, these are already really great changes!! It looks like you got all of the hex codes right, but weirdly it seems to be rendering the dark blue much lighter than it should. I'm unsure how to solve that problem. As you know, the dark blue hex code is #0D4984, which you have in your sourcecode. However, if you put the pre-release side by side, you see this dark blue is much lighter. |
@mmejia02 thankyou very much for your feedback , the dark blue color problem is not there in my browser and also i checked with the latest deploy preview link , also I have already replaced the text color of first container of homescreen with black color , do you want be to replace it with some different shade of black ? |
@ShravaniAK , in your browser it looks amazing and I have no other feedback!! Exciting stuff :) I still have no idea why my rendering is being weird but it's fine |
Okay let's merge this for now, and then @ShravaniAK can you try testing this on some other browsers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/unhold
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, ShravaniAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #6028
Proposed Changes