Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new design implementation for footer and removed the pre-footer section #6036

Merged
merged 5 commits into from
Jul 17, 2024
Merged

new design implementation for footer and removed the pre-footer section #6036

merged 5 commits into from
Jul 17, 2024

Conversation

ShravaniAK
Copy link
Contributor

resolves #6035

changes made :

  1. replaced the footer background colour.
  2. Move footer icons to the right.
  3. Remove the pre-footer section of the previous design.
  4. added space at the top of the cncf logo container.

proposed design :
Screenshot 2024-07-01 at 6 30 29 PM

Implementaion:

Screenshot 2024-07-01 at 6 30 45 PM

@ShravaniAK
new design implementation for footer and removed the pre-footer section
295c5d2 
Signed-off-by: SHRAVANI KAWARE <97099574+ShravaniAK@users.noreply.github.com>
@knative-prow knative-prow bot requested review from csantanapr and ReToCode July 1, 2024 13:03
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 1, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 1, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2043563
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/66912c44cd295a0008b9765d
😎 Deploy Preview https://deploy-preview-6036--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShravaniAK
Copy link
Contributor Author

/cc @Cali0707 @aliok

@knative-prow knative-prow bot requested review from aliok and Cali0707 July 1, 2024 13:06
Cali0707
Cali0707 suggested changes Jul 2, 2024
View reviewed changes
docs/stylesheets/extra.css Outdated Show resolved Hide resolved
docs/stylesheets/extra.css Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2024
@ShravaniAK ShravaniAK requested a review from Cali0707 July 2, 2024 14:53
@Cali0707
Copy link
Member

Hey @ShravaniAK thanks for your work so far on this! As you can see in this screenshot below, there is a spacing issue with the text:
image
Would you be able to fix this?

@ShravaniAK
Copy link
Contributor Author

@Cali0707 I have fixed the spacing issue , thanks !

@ShravaniAK ShravaniAK mentioned this pull request Jul 12, 2024
Merged
Cali0707
Cali0707 suggested changes Jul 12, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ShravaniAK - this looks a lot better now! I left one code quality comment and then we should be good to merge this

docs/stylesheets/extra.css Outdated Show resolved Hide resolved
@ShravaniAK
Copy link
Contributor Author

@Cali0707 I have removed the commented code, thanks.

Cali0707
Cali0707 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, ShravaniAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@knative-prow knative-prow bot merged commit 3377a60 into knative:main Jul 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@csantanapr csantanapr Awaiting requested review from csantanapr

@ReToCode ReToCode Awaiting requested review from ReToCode

@aliok aliok Awaiting requested review from aliok

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the new design for Footer and pre-footer section .
3 participants
@ShravaniAK @Cali0707 @knative-prow-robot