💄 We renamed those fields to , and we reflect that now in validation

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
knative · Dec 4, 2024 · b826388 · b826388
1 parent 3345c86
commit b826388
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/pkg/apis/sinks/v1alpha1/integration_sink_validation.go b/pkg/apis/sinks/v1alpha1/integration_sink_validation.go
@@ -66,7 +66,7 @@ func (spec *IntegrationSinkSpec) Validate(ctx context.Context) *apis.FieldError
 		// Additional validation for AWS S3 required fields
 		if spec.Aws.S3 != nil {
 			if spec.Aws.S3.Arn == "" {
-				errs = errs.Also(apis.ErrMissingField("aws.s3.bucketNameOrArn"))
+				errs = errs.Also(apis.ErrMissingField("aws.s3.arn"))
 			}
 			if spec.Aws.S3.Region == "" {
 				errs = errs.Also(apis.ErrMissingField("aws.s3.region"))
@@ -76,7 +76,7 @@ func (spec *IntegrationSinkSpec) Validate(ctx context.Context) *apis.FieldError
 		// Additional validation for AWS SQS required fields
 		if spec.Aws.SQS != nil {
 			if spec.Aws.SQS.Arn == "" {
-				errs = errs.Also(apis.ErrMissingField("aws.sqs.queueNameOrArn"))
+				errs = errs.Also(apis.ErrMissingField("aws.sqs.arn"))
 			}
 			if spec.Aws.SQS.Region == "" {
 				errs = errs.Also(apis.ErrMissingField("aws.sqs.region"))

diff --git a/pkg/apis/sinks/v1alpha1/integration_sink_validation_test.go b/pkg/apis/sinks/v1alpha1/integration_sink_validation_test.go
@@ -147,7 +147,7 @@ func TestIntegrationSinkSpecValidation(t *testing.T) {
 					},
 				},
 			},
-			want: apis.ErrMissingField("aws.sqs.queueNameOrArn"),
+			want: apis.ErrMissingField("aws.sqs.arn"),
 		},
 		{
 			name: "AWS SNS sink without TopicNameOrArn (invalid)",

diff --git a/pkg/apis/sources/v1alpha1/integration_validation.go b/pkg/apis/sources/v1alpha1/integration_validation.go
@@ -76,7 +76,7 @@ func (spec *IntegrationSourceSpec) Validate(ctx context.Context) *apis.FieldErro
 		// Additional validation for AWS SQS required fields
 		if spec.Aws.SQS != nil {
 			if spec.Aws.SQS.Arn == "" {
-				errs = errs.Also(apis.ErrMissingField("aws.sqs.queueNameOrArn"))
+				errs = errs.Also(apis.ErrMissingField("aws.sqs.arn"))
 			}
 			if spec.Aws.SQS.Region == "" {
 				errs = errs.Also(apis.ErrMissingField("aws.sqs.region"))

diff --git a/pkg/apis/sources/v1alpha1/integration_validation_test.go b/pkg/apis/sources/v1alpha1/integration_validation_test.go
@@ -170,7 +170,7 @@ func TestIntegrationSourceSpecValidation(t *testing.T) {
 					},
 				},
 			},
-			want: apis.ErrMissingField("aws.sqs.queueNameOrArn"),
+			want: apis.ErrMissingField("aws.sqs.arn"),
 		},
 		{
 			name: "AWS DDBStreams source without Table (invalid)",
-Original file line number
+Diff line change
@@ Expand Up / @@ -147,7 +147,7 @@ func TestIntegrationSinkSpecValidation(t *testing.T) { @@
     					},
     				},
     			},
-    			want: apis.ErrMissingField("aws.sqs.queueNameOrArn"),
+    			want: apis.ErrMissingField("aws.sqs.arn"),
     		},
     		{
     			name: "AWS SNS sink without TopicNameOrArn (invalid)",
@@ Expand Down @@