Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Integration API and use custom tags on structs for better readability #8321

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Nov 11, 2024

Proposed Changes

  • starting with custom tags for complicated camel properties, to make the source spec easier to read

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 11, 2024
@knative-prow knative-prow bot requested review from creydr and Leo6Leo November 11, 2024 08:58
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.58%. Comparing base (9d67389) to head (2167a43).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ler/integrationsource/resources/containersource.go 66.66% 2 Missing and 1 partial ⚠️
...kg/apis/sources/v1alpha1/integration_validation.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8321   +/-   ##
=======================================
  Coverage   64.58%   64.58%           
=======================================
  Files         373      373           
  Lines       22619    22619           
=======================================
  Hits        14609    14609           
  Misses       7244     7244           
  Partials      766      766           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@matzew
Copy link
Member Author

matzew commented Nov 18, 2024

@pierDipi if you have time, would be nice to take a look here. Is the first PR of a series of smaller changes and improvements.

On purpose I only used the "custom" camel tags only where we changed the field/property, yet

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
Copy link

knative-prow bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 63d4da5 into knative:main Nov 19, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants