Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add authorization conformance tests for Sequence and Parallel #8400

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Add authorization conformance tests for Sequence and Parallel #8400

merged 3 commits into from
Jan 13, 2025

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Jan 8, 2025 •
edited
Loading

Proposed Changes

  • Run AuthZ conformance tests for Sequence and Parallel
  • Use fully functional Sequence and Parallel as otherwise they return status code 500 when events are sent to them while EventPolicy is configured to allow the traffic through it (the happy/successful path). This is different from other resources like Broker or Channel - these return 202 even if no sink is connected to them.

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@knative-prow knative-prow bot added area/test-and-release Test infrastructure, tests or release size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.12%. Comparing base (2f165f1) to head (6c32544).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8400      +/-   ##
==========================================
- Coverage   64.22%   64.12%   -0.11%     
==========================================
  Files         388      388              
  Lines       23324    23339      +15     
==========================================
- Hits        14979    14965      -14     
- Misses       7550     7579      +29     
  Partials      795      795

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgencur
Copy link
Contributor Author

mgencur commented Jan 8, 2025

/test reconciler-tests

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2025
@mgencur
Copy link
Contributor Author

mgencur commented Jan 9, 2025

/test reconciler-tests

1 similar comment
@mgencur
Copy link
Contributor Author

mgencur commented Jan 9, 2025

/test reconciler-tests

Cali0707
Cali0707 reviewed Jan 9, 2025
View reviewed changes
test/rekt/features/sequence/oidc_feature.go
sequence.Install(name, cfg...)(ctx, t)
})

f.Setup("Sequence goes ready", sequence.IsReady(name))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also verify that the sequence is addressable here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Probably a good idea. Pushing a new commit that fixes it in a few more places.

Cali0707
Cali0707 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2025
@knative-prow knative-prow bot merged commit cd7c1c0 into knative:main Jan 13, 2025
35 of 36 checks passed
@mgencur
Copy link
Contributor Author

mgencur commented Jan 14, 2025

@Cali0707 Thanks for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgencur @Cali0707