Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sinks.knative.dev to namespaced ClusterRole #8432

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Add sinks.knative.dev to namespaced ClusterRole #8432

merged 1 commit into from
Jan 30, 2025

Conversation

pierDipi
Copy link
Member

These are roles that users can use to give their developers access to Knative Eventing resources and we're missing the sinks group.

Fixes #

Proposed Changes

  • Add sinks.knative.dev to namespaced ClusterRole

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Add `sinks.knative.dev` to namespaced ClusterRoles

Docs

@pierDipi
Add sinks.knative.dev to namespaced ClusterRole
1e5b32d 
These are roles that users can use to give their developers access
to Knative Eventing resources and we're missing the sinks group.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.10%. Comparing base (d243b91) to head (1e5b32d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8432   +/-   ##
=======================================
  Coverage   64.10%   64.10%           
=======================================
  Files         388      388           
  Lines       23363    23363           
=======================================
  Hits        14976    14976           
  Misses       7591     7591           
  Partials      796      796

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matzew
matzew approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

this will work too for IntegrationSink.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/cherry-pick release-1.17

@knative-prow-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi
Copy link
Member Author

/cherry-pick release-1.16

@knative-prow-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi
Copy link
Member Author

/test reconciler-tests

@pierDipi pierDipi mentioned this pull request Jan 30, 2025
Merged
@knative-prow knative-prow bot merged commit 73357a6 into knative:main Jan 30, 2025
32 checks passed
@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #8433

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Jan 30, 2025
Open
@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #8434

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @knative-prow-robot @matzew