-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Python Middleware v2 Scaffolding #2685
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nice for getting this started |
ec91040
to
182c74c
Compare
Inbuilt templates should be limited to a base http and cloudevent integration, with anything beyond this falling to the officially supported functions samples repository.
b813d8c
to
269a8b2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2685 +/- ##
===========================================
- Coverage 62.58% 44.64% -17.94%
===========================================
Files 131 110 -21
Lines 15598 15114 -484
===========================================
- Hits 9762 6748 -3014
- Misses 4908 7530 +2622
+ Partials 928 836 -92
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7f8f2a8
to
7cd0cc6
Compare
@lkingland: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
||
client := fn.New(fn.WithVerbose(true)) | ||
|
||
f, err := client.Init(fn.Function{Root: root, Runtime: "python"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the unit test is failing on this
--- FAIL: TestBuilder_BuildPython (0.72s)
builder_test.go:68: exec: "python": executable file not found in $PATH
I guess the CI server does need updates?
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Changes
🎁 Host builder now supports Python Functions
🎁 Can now
func run
Python Functions locally outside of a container (no container runtime required)🎁 Python Functions now suppport instanced method signatures
🎁 Python Functions now support lifecycle events (start, stop, readiness, liveness)
🎁 Updates Python Template Tests to use pytest
🎁 Python Functions now use the ASGI Spec and run using an ASGI optimized server
🎁 adds support for base images to the OCI builder
🧹 Cleans up .gitignore
🧹 Cleans up and simplifies the OCI builder
🧹 Cleans up and simplifies the repository management code
🧹 removes broken interactive prompts from the
run
command pending forthcoming UX update/kind enhancement
Fixes #
Release Note
Docs