-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go-containerregistry dependency #15754
Conversation
/assign @skonto |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15754 +/- ##
==========================================
- Coverage 80.81% 80.78% -0.04%
==========================================
Files 222 222
Lines 18075 18075
==========================================
- Hits 14607 14601 -6
- Misses 3098 3101 +3
- Partials 370 373 +3 ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
capturing linter error here - #15755 it is a know issue /override "style / Golang / Lint" |
@dprotaso: Overrode contexts on behalf of dprotaso: style / Golang / Lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
User reported k8schain was failing with serving but not with the latest version of go-containerregistry.
See: https://cloud-native.slack.com/archives/C04LGHDR9K7/p1738857680364749
This bumps the ggcr dependency. They can test tomorrow when a nightly comes out - afterwards we can cherry pick changes.