Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-containerregistry dependency #15754

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Feb 6, 2025

User reported k8schain was failing with serving but not with the latest version of go-containerregistry.

See: https://cloud-native.slack.com/archives/C04LGHDR9K7/p1738857680364749

This bumps the ggcr dependency. They can test tomorrow when a nightly comes out - afterwards we can cherry pick changes.

Bump go-containerregistry to address issues with tag to digest resolution on EKS

@dprotaso
Copy link
Member Author

dprotaso commented Feb 6, 2025

/assign @skonto

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 6, 2025
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@knative-prow knative-prow bot requested review from dsimansk and skonto February 6, 2025 18:36
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.78%. Comparing base (a9c5467) to head (021a9fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15754      +/-   ##
==========================================
- Coverage   80.81%   80.78%   -0.04%     
==========================================
  Files         222      222              
  Lines       18075    18075              
==========================================
- Hits        14607    14601       -6     
- Misses       3098     3101       +3     
- Partials      370      373       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Feb 6, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2025
Copy link

knative-prow bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member Author

dprotaso commented Feb 6, 2025

capturing linter error here - #15755 it is a know issue

/override "style / Golang / Lint"

Copy link

knative-prow bot commented Feb 6, 2025

@dprotaso: Overrode contexts on behalf of dprotaso: style / Golang / Lint

In response to this:

capturing linter error here - #15755 it is a know issue

/override "style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 817e853 into knative:main Feb 6, 2025
68 of 69 checks passed
@dprotaso dprotaso deleted the bump-ggcr branch February 6, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants