Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KNO-7623): add MsTeamsChannelCombobox to docs #759

Conversation

mattmikolay
Copy link
Contributor

@mattmikolay mattmikolay commented Jan 27, 2025

Description

This PR updates the documentation to reflect the addition of MsTeamsChannelCombobox to TeamsKit. As usual, I’ve modeled these changes after existing SlackKit docs.

I’ll only merge this PR once MsTeamsChannelCombobox is released.

Tasks

KNO-7623

Copy link

linear bot commented Jan 27, 2025

Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 4:09pm

Comment on lines +678 to +679
name="slackChannelsRecipientObject*"
type="RecipientObject"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

knocklabs/javascript#359 renamed ContainerObject to RecipientObject.

In addition, the prop is named slackChannelsRecipientObject, with an s.

Copy link
Contributor

@JEverhart383 JEverhart383 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo nit, a few suggestions - approving to unblock merge

mattmikolay and others added 2 commits January 29, 2025 11:07
Co-authored-by: Jeff Everhart <Jeffeverhart383@gmail.com>
Co-authored-by: Jeff Everhart <Jeffeverhart383@gmail.com>
@mattmikolay mattmikolay merged commit 51e6652 into main Jan 29, 2025
3 checks passed
@mattmikolay mattmikolay deleted the mattmik-kno-7623-update-docs-to-reflect-addition-of-msteamschannelcombobox branch January 29, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants