-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(KNO-7623): add MsTeamsChannelCombobox to docs #759
feat(KNO-7623): add MsTeamsChannelCombobox to docs #759
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
name="slackChannelsRecipientObject*" | ||
type="RecipientObject" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
knocklabs/javascript#359 renamed ContainerObject
to RecipientObject
.
In addition, the prop is named slackChannelsRecipientObject
, with an s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo nit, a few suggestions - approving to unblock merge
Co-authored-by: Jeff Everhart <Jeffeverhart383@gmail.com>
Co-authored-by: Jeff Everhart <Jeffeverhart383@gmail.com>
Description
This PR updates the documentation to reflect the addition of
MsTeamsChannelCombobox
to TeamsKit. As usual, I’ve modeled these changes after existing SlackKit docs.I’ll only merge this PR once
MsTeamsChannelCombobox
is released.Tasks
KNO-7623