function pause working #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npyka-nokia
reviewed
Jul 15, 2022
| void Controller::receive(std::unique_ptr<Event> e) | ||
| { | ||
| switch(e->getMessageId()) | ||
| /* |
There was a problem hiding this comment.
No need to commit the code that is commented out - YAGNI rule :)
npyka-nokia
reviewed
Jul 15, 2022
| case TimeoutInd::MESSAGE_ID: return handleTimePassed(*static_cast<EventT<TimeoutInd> const&>(*e)); | ||
| case DirectionInd::MESSAGE_ID: return handleDirectionChange(*static_cast<EventT<DirectionInd> const&>(*e)); | ||
| case TimeoutInd::MESSAGE_ID: | ||
| if(!PouseON){ |
There was a problem hiding this comment.
For clarity you may check PauseON value in the beginning of the method and just return immediately if it is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.