Solved problem #3 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npyka-nokia
reviewed
Jul 15, 2022
| @@ -33,11 +33,14 @@ class Controller : public IEventHandler | |||
| void receive(std::unique_ptr<Event> e) override; | |||
|
|
|||
| private: | |||
| bool paused = false; | |||
There was a problem hiding this comment.
Would go with a name showing condition that the bool variable is checking, i.e. isPaused here.
npyka-nokia
reviewed
Jul 15, 2022
| @@ -150,6 +157,20 @@ void Controller::handleNewFood(const FoodResp& requestedFood) | |||
| m_foodPosition = std::make_pair(requestedFood.x, requestedFood.y); | |||
| } | |||
|
|
|||
| void Controller::handlePauseState(const PauseInd&) | |||
| { | |||
| (paused == false) ? (paused = true) : (paused = false); | |||
npyka-nokia
reviewed
Jul 15, 2022
| void Controller::handlePauseState(const PauseInd&) | ||
| { | ||
| (paused == false) ? (paused = true) : (paused = false); | ||
| /* |
There was a problem hiding this comment.
No need to commit the commented code - YAGNI rule :)
npyka-nokia
reviewed
Jul 15, 2022
| } | ||
|
|
||
| void Controller::handleDirectionChange(const DirectionInd& directionInd) | ||
| { | ||
| if(!paused){ |
There was a problem hiding this comment.
To remove number of indentations you can just write:
if (paused) return;
Will be easier to track later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for late request, I've had some stupid problems with token