My solution #9
Open
My solution #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokotg
reviewed
Jul 15, 2022
| @@ -66,6 +68,8 @@ class Controller : public IEventHandler | |||
|
|
|||
| Direction m_currentDirection; | |||
| std::list<Segment> m_segments; | |||
|
|
|||
| bool paused = false; | |||
There was a problem hiding this comment.
should be m_ as other members in this class; please try to follow convention that is used in specific project; it may be different, but usually it is better to follow convention that is used in specific project
kokotg
reviewed
Jul 15, 2022
| if (segment.x == requestedFood.x and segment.y == requestedFood.y) { | ||
| requestedFoodCollidedWithSnake = true; | ||
| break; | ||
| if(!paused){ |
There was a problem hiding this comment.
maybe it would be better to check this flag in one function (for example in recive() method before calling handleNewFood() instead of putting it here. This way you handle the pause functionality in one function instead of body of other functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.