Fix Text::installation() bounding box positioning under transformat…

…ion.
kpreid · Dec 3, 2023 · dd283d9 · dd283d9
1 parent a9326fb
commit dd283d9
Showing 1 changed file with 20 additions and 15 deletions.
diff --git a/all-is-cubes/src/block/text.rs b/all-is-cubes/src/block/text.rs
@@ -95,28 +95,33 @@ impl Text {
     /// Each individual block is given to `block_fn` to allow alterations.
     ///
     /// The transaction has no preconditions.
+    ///
+    /// Panics if `transform` causes coordinate overflow.
     pub fn installation(
         &self,
         transform: Gridgid,
         block_fn: impl Fn(Block) -> Block,
     ) -> SpaceTransaction {
         let dst_to_src_transform = transform.inverse();
         let block_rotation = transform.rotation;
-        SpaceTransaction::filling(self.bounding_blocks(), |cube| {
-            space::CubeTransaction::replacing(
-                None,
-                Some(block_fn(
-                    Block::from_primitive(block::Primitive::Text {
-                        text: self.clone(),
-                        offset: dst_to_src_transform
-                            .transform_cube(cube)
-                            .lower_bounds()
-                            .to_vector(),
-                    })
-                    .rotate(block_rotation),
-                )),
-            )
-        })
+        SpaceTransaction::filling(
+            self.bounding_blocks().transform(transform).unwrap(),
+            |cube| {
+                space::CubeTransaction::replacing(
+                    None,
+                    Some(block_fn(
+                        Block::from_primitive(block::Primitive::Text {
+                            text: self.clone(),
+                            offset: dst_to_src_transform
+                                .transform_cube(cube)
+                                .lower_bounds()
+                                .to_vector(),
+                        })
+                        .rotate(block_rotation),
+                    )),
+                )
+            },
+        )
     }
 
     pub(crate) fn evaluate(