Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wgpu dep to 0.19.0. #449

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Update wgpu dep to 0.19.0. #449

merged 5 commits into from
Jan 22, 2024

Conversation

kpreid
Copy link
Owner

@kpreid kpreid commented Jan 18, 2024

This requires some compromises:

  • rend3 is not yet officially updated for 0.19, and due to the web-sys unstable WebGPU feature mess we can't have both versions of wgpu in our tree. So, I forked and patched it (and sent a PR).
  • simplelog has a pinned version of termcolor. We can disable its colored output for now, but we may wish to replace simplelog with a different logging implementation. (Tracking: Choose a new logging backend #453)
  • There is a bug in Rust 1.75 that causes cargo doc to hang when documenting wgpu-core. This will be fixed in the next release, at which point we should revert the usage of --no-deps for docs in this PR. (Tracking: Revert using cargo doc --no-deps when Rust 1.76 is released #452).

@kpreid kpreid force-pushed the wgpu-next2 branch 3 times, most recently from efaf0e8 to 0a82250 Compare January 22, 2024 20:29
This is a temporary or maybe permanent workaround for `simplelog` having
a restrictive version requirement of `termcolor = "1.1.*"`, which
conflicts with newer `naga`. We lose colored logging.
This works around a rustdoc bug provoked by wgpu-core 0.19.0.
This commit should be reverted when Rust 1.76 is released.
Due to `web-sys` unstable feature conflicts, we must also update `rend3`.
Since that is just for testing and a git dependency already, I've updated
it to a personal fork for now.
This was fixed by <gfx-rs/wgpu#4701>
in wgpu version 0.19.
@kpreid kpreid merged commit 38afeda into main Jan 22, 2024
12 of 13 checks passed
@kpreid kpreid deleted the wgpu-next2 branch January 22, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant