Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General documentation improvements #215

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Nov 23, 2023

This PR includes a bunch of general docs improvements:

  • Typos and grammar fixes
  • Switch from a markdown table to MyST list table in alternatives.md
  • Removed tab groups and inlined code comparisons in alternatives.md
  • Add lots of `{py:func}kr8s.foo()` references
  • Improve some docstrings

I also removed a test that was asserting some docstring equality. I'm not sure we actually want to ensure these are identical as some are async and some are not. Also despite the __doc__ being equal the Sphinx site wasn't rendering some of them correctly.

@github-actions github-actions bot added documentation Improvements or additions to documentation kr8s labels Nov 23, 2023
@github-actions github-actions bot added the tests label Nov 23, 2023
@jacobtomlinson jacobtomlinson merged commit a5b2b11 into kr8s-org:main Nov 23, 2023
7 checks passed
@jacobtomlinson jacobtomlinson deleted the docs-updates branch November 23, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation kr8s tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant