Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass kwargs along in APIObjectSyncMixin.list() #554

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

jacobtomlinson
Copy link
Member

Fixed regression reported in #553

Closes #553

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.09%. Comparing base (87063fc) to head (b272e63).
Report is 163 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   94.61%   94.09%   -0.53%     
==========================================
  Files          29       30       +1     
  Lines        3141     4164    +1023     
==========================================
+ Hits         2972     3918     +946     
- Misses        169      246      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit d19b6c1 into kr8s-org:main Jan 22, 2025
13 checks passed
@jacobtomlinson jacobtomlinson deleted the fix-553 branch January 22, 2025 10:31
@jacobtomlinson jacobtomlinson added bug Something isn't working typing labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kr8s tests typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't provide any args to list (sync)
1 participant