Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit type hints for APIObjectSyncMixin methods #561

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Jan 22, 2025

Add explicit type hints to APIObjectSyncMixin methods.

Closes #559

@jacobtomlinson jacobtomlinson added bug Something isn't working typing labels Jan 22, 2025
@github-actions github-actions bot added the kr8s label Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.10%. Comparing base (87063fc) to head (6915d07).
Report is 168 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
- Coverage   94.61%   94.10%   -0.52%     
==========================================
  Files          29       30       +1     
  Lines        3141     4175    +1034     
==========================================
+ Hits         2972     3929     +957     
- Misses        169      246      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson changed the title Add explicit type hint for APIObjectSyncMixin.list() Add explicit type hints for APIObjectSyncMixin methods Jan 22, 2025
@jacobtomlinson jacobtomlinson merged commit 0036e77 into kr8s-org:main Jan 22, 2025
12 checks passed
@jacobtomlinson jacobtomlinson deleted the sync-mixin-list-typehint branch January 22, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kr8s typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod.list typehint returning -> Generator[Unknown, Unknown, None]
1 participant