Strict mode #7
Merged
Strict mode #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To give client code more control about what exceptions it catches.
seddonym
force-pushed
the
strict-mode
branch
from
bd7a8ec to
80f482d
Compare
seddonym
commented
Sep 23, 2024
| @@ -37,8 +42,9 @@ impl Bundle { | |||
| Ok(resource) => resource, | |||
| Err(error) => { | |||
| if strict { | |||
| return Err(PyValueError::new_err(format!( | |||
| "{error:?} - Fluent file contains errors" | |||
There was a problem hiding this comment.
The debug output of the error class was really long and difficult to read. Ideally we would have an errors attribute on the Python exception which contains each error as structured data. Happy to use the original error message for the time being though if you feel it's better.
dooferlad
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional
strictparameter to theBundleconstructor, allowing client code to decide whether an exception should be raised if the fluent file contains errors.I did hope to add more structured information to the
ParserError, so we could see which lines had errors in, but I couldn't quickly work out how to define exceptions in Py03 that have custom fields. (In its current form, the string-based reporting is too long to read, IMO).I think it's probably worth merging like this as-is and then tackle better error reporting in a follow up, but open to being talked out of that! 😄