Use fci.named_params similar to how PHP handles CUFA #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmb69 can you approve the workflow? |
|
It looks like the failing CI is actually caused by the recent upgrade of ubuntu-latest to Ubuntu 24.04. Need to have a look at this. |
|
I do have 4 tests failing locally, but I don't know if that's because I linked it against an old master build dating back from July, or something else. |
|
Ci should be okay again; can you please rebase? And maybe you want to have a look at #185; would like some review on that. :) |
Girgias
force-pushed
the
fcall_info_ex-to-named-params
branch
from
fd044bc to
e747c7f
Compare
|
Rebased, will need an approval for the workflow again (thank crypto miners using GH CI....) |
|
Welcome simplification. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.