Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Remove extra page padding #763

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Feb 5, 2025

Description

In integrated mode, we want to mimic as much as possible other deployments.

Before (Integrated Mode):
Screenshot 2025-01-27 at 15 34 09

Before (Standalone Mode):
Screenshot 2025-02-05 at 3 27 56 PM

After (Standalone Mode):
Screenshot 2025-02-05 at 3 23 07 PM

Target:
Screenshot 2025-01-27 at 15 34 19

How Has This Been Tested?

  1. Go to Model Registry list view and verify that styling and padding of the page component aligns with integrated mode.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link

@adysenrothman adysenrothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

@adysenrothman: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adysenrothman
Once this PR has been reviewed and has the lgtm label, please assign griffin-sullivan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com>

fix(frontend): update margin styling to fix breakpoint issue
@jenny-s51 jenny-s51 force-pushed the remove-extra-padding branch from 7fbf591 to 0454900 Compare February 6, 2025 19:57
Copy link
Contributor Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing @lucferbux @adysenrothman !

@lucferbux fixed the margin styling based on your feedback - the resize should now work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants