Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Fix breadcrumb padding #792

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

jenny-s51
Copy link
Member

@jenny-s51 jenny-s51 commented Feb 11, 2025

Description

Updated the padding on the breadcrumb to align with the page title in the Model Versions list view.

Before:
Screenshot 2025-02-11 at 2 00 05 PM
Screenshot 2025-02-11 at 2 44 17 PM

After:
Screenshot 2025-02-11 at 2 41 25 PM
Screenshot 2025-02-11 at 2 44 03 PM

How Has This Been Tested?

  1. Navigate to Model Registry list view.
  2. Click on a model.
  3. Verify the breadcrumb is aligned with the page title.
  4. Click on a model version.
  5. Verify the breadcrumb is aligned with the page title.

Tests N/A, visual updates only.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@jenny-s51 jenny-s51 changed the title fix(frontend): fix breadcrumb padding fix(frontend): Fix breadcrumb padding Feb 11, 2025
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
@jenny-s51 jenny-s51 force-pushed the fix-breadcrumb-padding branch from 411d9aa to ace4d34 Compare February 11, 2025 20:23
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 796ac44 into kubeflow:main Feb 12, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants