Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): debug logs on data plane for health service addresses #356

Merged
merged 6 commits into from
Jan 28, 2025
Merged

(feat): debug logs on data plane for health service addresses #356

merged 6 commits into from
Jan 28, 2025

Conversation

buraksekili
Copy link
Contributor

This PR

  • adds debug and info logs to print out addresses & ports being used by data plane for gRPC health service.
  • updates xtask command to run data plane with debug log level for api_server
  • fixes incorrect xtask command name for controlplane (typo).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2025
@shaneutt shaneutt requested review from aryan9600 and removed request for astoycos January 28, 2025 15:11
@shaneutt shaneutt added tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. labels Jan 28, 2025
shaneutt
shaneutt requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you for taking the time to do this.

My comments are mostly minor things, take a look and let me know what you think.

dataplane/api-server/src/lib.rs Show resolved Hide resolved
dataplane/api-server/src/lib.rs Outdated Show resolved Hide resolved
dataplane/api-server/src/lib.rs Outdated Show resolved Hide resolved
dataplane/api-server/src/lib.rs Outdated Show resolved Hide resolved
dataplane/api-server/src/lib.rs Outdated Show resolved Hide resolved
dataplane/api-server/src/lib.rs Show resolved Hide resolved
xtask/src/run.rs Show resolved Hide resolved
buraksekili and others added 2 commits January 28, 2025 19:31
@buraksekili @shaneutt
Update dataplane/api-server/src/lib.rs
afdd4b2 
Co-authored-by: Shane Utt <shane@shaneutt.com>
Signed-off-by: Burak Sekili <32663655+buraksekili@users.noreply.github.com>
@buraksekili
Remove extra logging for panic errors; instead panic with expect.
5018739 
Remove redundant log about api_server addr; update log statements to
include `{addr}:{port}` combination.
@buraksekili
Copy link
Contributor Author

thanks for the review @shaneutt! i've updated the code accordingly

shaneutt
shaneutt approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buraksekili, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4960d1b into kubernetes-sigs:main Jan 28, 2025
5 checks passed
@buraksekili buraksekili deleted the feat/dp-debug-logs branch January 28, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

@aryan9600 aryan9600 Awaiting requested review from aryan9600

Assignees

@shaneutt shaneutt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
Blixt Project Board
Status: Done
Milestone
v0.4.0 - Rewrite of the control-plane...
Development

Successfully merging this pull request may close these issues.
3 participants
@buraksekili @k8s-ci-robot @shaneutt