Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proposal for assigning additional listener to specific machines #2173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add proposal for assigning additional listener to specific machines #2173

wants to merge 2 commits into from

Conversation

Shilpa-Gokul
Copy link
Contributor

What this PR does / why we need it:
Adds a proposal to support assigning additional listeners to specific machines based on label selectors.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Feb 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shilpa-Gokul
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Shilpa-Gokul. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 5, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 5, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit a08663e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/67a4392c1acbd600082c18fd
😎 Deploy Preview https://deploy-preview-2173--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shilpa-Gokul Shilpa-Gokul changed the title [WIP]: Add proposal for assigning additional listener to specific machines Add proposal for assigning additional listener to specific machines Feb 5, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2025
Karthik-K-N
Karthik-K-N reviewed Feb 5, 2025
View reviewed changes
docs/proposal/additional-listener.md Outdated Show resolved Hide resolved
docs/proposal/additional-listener.md Outdated

[Github Issue](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/issues/1678)
## Motivation
Currently, when a listener pool is configured for a specific port (e.g., port 22), all machines are added to the pool.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be like, When configuring Loadbalancer's additional listeners, all the machines are added to Listenr's pool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

docs/proposal/additional-listener.md Outdated
[Github Issue](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/issues/1678)
## Motivation
Currently, when a listener pool is configured for a specific port (e.g., port 22), all machines are added to the pool.
This creates a challenge when debugging OpenShift cluster deployments, as access to the bootstrap node is necessary for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not mention anything like Openshift, It should be generic. But you can mention you want to ssh to particular machine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

docs/proposal/additional-listener.md Outdated
Comment on lines 88 to 91
The load balancer details are retrieved from the IBMPowerVSCluster.Spec.LoadBalancers. If no load balancers are
specified in the Spec, the load balancer details are generated based on the IBMPowerVSCluster name.
Loop through the load balancers, check the status of the IBMPowerVSCluster, and verify the load balancer's
provisioning status. Proceed only if the status is Active and it contains backend pools.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think existing flow need not be mentioned. Lets only mention how we are changing the flow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed old flow

docs/proposal/additional-listener.md
can be assigned to control plane machines.

### Workflow
![additional-listeners-workflow](../images/additional-listener-workflow.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In diagram to start with
IBMPowerVSCluster -> Loadbalancers

In parallel flow lets mention
IBMPowerVSMachine -> IBMPowerVSMachine.Lables == selector

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karthik-K-N Karthik-K-N Karthik-K-N left review comments

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

Assignees
No one assigned
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shilpa-Gokul @k8s-ci-robot @Karthik-K-N