-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the ability to apply extra volumes and volume mounts to the daemonset #1322
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: FutureMatt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @FutureMatt. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hey, is some one able to take a look at this? |
Looks good. Thanks @FutureMatt . Have you tried tested it in your own env? |
What this PR does / why we need it:
Adds the ability for the end-user to mount extra volumes into the DaemonSet pod. In our instance we want to leverage the CA file configuration option to validate the vCenter instance we are connecting to and this needs to be mounted in the pod.
I also spotted that the affinity parameters were missing from the readme so I added that too.