Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix waiting for all pods having specified labels to be Ready #20315

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

prezha
Copy link
Contributor

@prezha prezha commented Jan 26, 2025

fixes #19288

this pr ensures that, when requested (via --wait flag), we wait until all (at least one) pods that have one of the CorePodsLabels in the kube-system namespace to be "Ready" or timeout


note: this pr should be merged after #20313 (and then rebase, solving expected conflicts)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 26, 2025
@prezha
Copy link
Contributor Author

prezha commented Jan 26, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 26, 2025
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@prezha prezha changed the title Fix waiting for all pods having one of specified labels to be Ready [WIP] Fix waiting for all pods having specified labels to be Ready Jan 27, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 27, 2025
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20315) |
+----------------+----------+---------------------+
| minikube start | 48.4s    | 49.2s               |
| enable ingress | 14.6s    | 15.1s               |
+----------------+----------+---------------------+

Times for minikube start: 46.2s 50.3s 47.6s 49.4s 48.5s
Times for minikube (PR 20315) start: 49.6s 48.0s 50.6s 49.8s 48.1s

Times for minikube ingress: 14.4s 14.5s 14.9s 14.4s 14.9s
Times for minikube (PR 20315) ingress: 14.9s 14.9s 14.9s 15.9s 14.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20315) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.5s               |
| enable ingress | 12.9s    | 12.4s               |
+----------------+----------+---------------------+

Times for minikube start: 23.9s 24.0s 20.2s 19.9s 22.7s
Times for minikube (PR 20315) start: 23.3s 20.2s 19.8s 20.2s 24.0s

Times for minikube ingress: 12.8s 12.7s 13.2s 12.7s 13.2s
Times for minikube (PR 20315) ingress: 12.2s 12.2s 12.7s 12.2s 12.7s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20315) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 21.9s               |
| enable ingress | 39.1s    | 39.0s               |
+----------------+----------+---------------------+

Times for minikube start: 21.6s 22.7s 23.0s 22.6s 22.7s
Times for minikube (PR 20315) start: 19.1s 23.3s 22.3s 22.6s 22.3s

Times for minikube ingress: 39.2s 39.2s 38.8s 39.2s 39.2s
Times for minikube (PR 20315) ingress: 38.7s 38.8s 39.3s 39.2s 39.2s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux (2 failed) TestFunctional/parallel/MountCmd/specific-port(gopogh) 0.00% (chart)
Docker_Linux (2 failed) TestMultiNode/serial/RestartMultiNode(gopogh) 0.00% (chart)
Docker_Linux_containerd_arm64 (1 failed) TestScheduledStopUnix(gopogh) 9.80% (chart)
Docker_Linux_crio_arm64 (3 failed) TestScheduledStopUnix(gopogh) 5.88% (chart)
Docker_Linux_crio_arm64 (3 failed) TestFunctional/parallel/PersistentVolumeClaim(gopogh) 10.87% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--wait flag sometimes misses pods
3 participants