-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix waiting for all pods having specified labels to be Ready #20315
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prezha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kvm2 driver with docker runtime
Times for minikube start: 46.2s 50.3s 47.6s 49.4s 48.5s Times for minikube ingress: 14.4s 14.5s 14.9s 14.4s 14.9s docker driver with docker runtime
Times for minikube start: 23.9s 24.0s 20.2s 19.9s 22.7s Times for minikube ingress: 12.8s 12.7s 13.2s 12.7s 13.2s docker driver with containerd runtime
Times for minikube start: 21.6s 22.7s 23.0s 22.6s 22.7s Times for minikube ingress: 39.2s 39.2s 38.8s 39.2s 39.2s |
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
fixes #19288
this pr ensures that, when requested (via
--wait
flag), we wait until all (at least one) pods that have one of the CorePodsLabels in the kube-system namespace to be "Ready" or timeoutnote: this pr should be merged after #20313 (and then rebase, solving expected conflicts)