Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tunnel metrics #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix tunnel metrics #32

wants to merge 3 commits into from
+42,676 −17,794

Conversation

kmjayadeep
Copy link
Contributor

@kmjayadeep kmjayadeep commented May 25, 2023 •
edited
Loading

This PR improves metrics implementation and fixes existing metrics in gateway sidecar

  • Replace metrics implementation with monitoring framework library
  • Use standard labels and names for metrics
  • Fix: TxRate and RxRate were coming as 0 always
  • Go fmt fixes

kmjayadeep added 3 commits May 21, 2023 12:36
@kmjayadeep
fix tunnel metrics
c4cab63 
Signed-off-by: Jayadeep KM <kmjayadeep@gmail.com>
@kmjayadeep
migrate to monitoring framework
7ceab49 
Signed-off-by: Jayadeep KM <kmjayadeep@gmail.com>
@kmjayadeep
add tunnel up metric
6e4895e 
Signed-off-by: Jayadeep KM <kmjayadeep@gmail.com>
@kmjayadeep kmjayadeep mentioned this pull request May 25, 2023
Closed
@kmjayadeep kmjayadeep marked this pull request as ready for review May 25, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajendra-avesha rajendra-avesha rajendra-avesha approved these changes

@Rahul-D78 Rahul-D78 Awaiting requested review from Rahul-D78

@YachikaRalhan YachikaRalhan Awaiting requested review from YachikaRalhan

@bharath-avesha bharath-avesha Awaiting requested review from bharath-avesha

@gourishkb gourishkb Awaiting requested review from gourishkb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmjayadeep @rajendra-avesha