-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MeshRateLimit): add support for new api rules in MeshRateLimit #12722
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@@ -11,6 +11,7 @@ import ( | |||
core_xds "github.com/kumahq/kuma/pkg/core/xds" | |||
"github.com/kumahq/kuma/pkg/plugins/policies/core/matchers" | |||
core_rules "github.com/kumahq/kuma/pkg/plugins/policies/core/rules" | |||
inbound2 "github.com/kumahq/kuma/pkg/plugins/policies/core/rules/inbound" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would name it better, maybe rules_inbound
?
|
||
if err := configure(rules, listener, nil); err != nil { | ||
conf := inbound2.MatchesAllIncomingTraffic[api.Conf](fromRules.InboundRules[listenerKey]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can fromRules.InboundRules[listenerKey]
be empty and should we skip in this case?
Motivation
We've added new rules api for inbound policies, we need to implement it for MeshRateLimit
Fix #12370