Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Size][KDEV-66627][KDEV-66628] Add Nantes and NotificationView to Package Dependencies #114

Conversation

raymondjoneskustomer
Copy link
Contributor

@raymondjoneskustomer raymondjoneskustomer commented Sep 25, 2024

[KDEV-66627][KDEV-66628]

These 2 dependencies will be marked as Implementation Only, which will require them to be here to not break CI

@raymondjoneskustomer raymondjoneskustomer changed the title add nantes and notification view [KDEV-66627][KDEV-66628] Add Nantes and NotificationView to Package Dependencies Sep 25, 2024
@raymondjoneskustomer raymondjoneskustomer marked this pull request as ready for review September 25, 2024 17:19
@raymondjoneskustomer raymondjoneskustomer requested a review from a team September 25, 2024 17:19
@raymondjoneskustomer raymondjoneskustomer changed the title [KDEV-66627][KDEV-66628] Add Nantes and NotificationView to Package Dependencies [Size][KDEV-66627][KDEV-66628] Add Nantes and NotificationView to Package Dependencies Sep 25, 2024
…cation-view

# Conflicts:
#	KustomerChat.podspec
#	Package.swift
@emre-ozsahin
Copy link

@raymondjoneskustomer looks like there seems to be a conflict with dependencies here.

@raymondjoneskustomer
Copy link
Contributor Author

@raymondjoneskustomer looks like there seems to be a conflict with dependencies here.

@emre-ozsahin resolved

@raymondjoneskustomer raymondjoneskustomer merged commit 15fdc69 into main Sep 27, 2024
2 checks passed
@raymondjoneskustomer raymondjoneskustomer deleted the raymond.jones/kdev-66627-66628-nantes-notification-view branch September 27, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants