node: use bootpeers in mocknet test instead of force connect #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchappelow
commented
Feb 4, 2025
| @@ -381,7 +385,8 @@ func TestDualNodeMocknet(t *testing.T) { | |||
| } | |||
| ps2, err := NewP2PService(ctx, psCfg2, h2) | |||
| require.NoError(t, err) | |||
| err = ps2.Start(ctx) | |||
| err = ps2.Start(ctx, peerStr1) | |||
There was a problem hiding this comment.
^ The bootpeers change here is having p2p service number 2 connect to the host number 1's p2p service.
I still don't get what happens in the CI failures, but it complains about missing protocol IDS, which is strange since all the protocol ids should have been set long before the nodes were linked and connected.
charithabandi
approved these changes
Feb 4, 2025
|
Will merge this after the beta.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
TestDualNodeMocketuse bootpeers like real apps rather than having the mocknet do it'sConnectAllButSelfmagic. Let's see if CI and my machine like this better.More generally, we've started doing much more outside of the
Nodeconstructor andStart, so it might make sense to have these quick in-memory tests in some other node_test package that uses the server construction stuff inapp/nodedirectly so this is closer to reality. This test came about before there was even an app usingNode.