Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shorten intermediate outputs of the companion #358

Merged
merged 18 commits into from
Feb 10, 2025

Conversation

tanweersalah
Copy link
Contributor

@tanweersalah tanweersalah commented Jan 27, 2025

Description

Changes proposed in this pull request:

  • Removed Summarize Node from output chunk
  • Made all the output chunks consistent
  • Added subtask with a shorten steps description which can be shown to the user in frontend

Related issue(s)

#335

Copy link

Note(s) for PR Auther:

  • The integration test will be skipped for the PR. You can trigger it manually after adding the label: run-integration-test.
  • The evaluation test will be skipped for the PR. You can trigger it manually after adding the label: evaluation requested.
  • If any changes are made to the evaluation tests data, make sure that the integration tests are working as expected.
  • If any changes are made to how to run the unit tests, make sure to update the steps for unit-tests in the create-release.yml workflow as well.

Note(s) for PR Reviewer(s):

  • Make sure that the integration and evaluation tests are working as expected.

@tanweersalah tanweersalah changed the title feat: Shorten intermediate outputs of the companion feat: shorten intermediate outputs of the companion Jan 27, 2025
@tanweersalah tanweersalah linked an issue Jan 27, 2025 that may be closed by this pull request
1 task
@tanweersalah tanweersalah marked this pull request as ready for review February 4, 2025 09:23
@tanweersalah tanweersalah requested a review from a team as a code owner February 4, 2025 09:23
@kyma-bot kyma-bot added size/XL and removed size/M labels Feb 4, 2025
@tanweersalah tanweersalah added run-integration-test evaluation requested A PR with this label will trigger the validation workflow. and removed evaluation requested A PR with this label will trigger the validation workflow. run-integration-test labels Feb 4, 2025
@tanweersalah tanweersalah added evaluation requested A PR with this label will trigger the validation workflow. run-integration-test labels Feb 6, 2025
src/agents/common/state.py Outdated Show resolved Hide resolved
src/agents/common/state.py Outdated Show resolved Hide resolved
tanweersalah and others added 2 commits February 10, 2025 13:50
Co-authored-by: Friedrich <jens.wilken@sap.com>
Co-authored-by: Friedrich <jens.wilken@sap.com>
@kyma-bot kyma-bot added the lgtm label Feb 10, 2025
@kyma-bot kyma-bot merged commit 40e2ffa into kyma-project:main Feb 10, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes evaluation requested A PR with this label will trigger the validation workflow. lgtm run-integration-test size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shorten intermediate outputs of the companion
3 participants