Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a broken link, adjust the Observebility tutorials doc #18501

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

nataliasitko
Copy link
Contributor

Description

Changes proposed in this pull request:

Related issue(s)

@nataliasitko nataliasitko requested a review from a team as a code owner December 20, 2023 10:55
Copy link

netlify bot commented Dec 20, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 76e7f7f

Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 76e7f7f
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/6582ed3ba0a8b700085bcf3d
😎 Deploy Preview https://deploy-preview-18501--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2023
@@ -8,6 +8,4 @@ If you're interested in learning more about the Telemetry module and how to inte

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 3, I suggest:

If you're interested in using our Telemetry module to integrate with backends, check out our Integration Guides.

Delete lines 5-10, they're all in the integration guides now.
Keep line 11, this example cannot yet move to the Telemetry repo.

@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 20, 2023
@kyma-bot kyma-bot merged commit e2c22b7 into kyma-project:main Dec 20, 2023
4 checks passed
@nataliasitko nataliasitko changed the title Fix a broken link Fix a broken link, adjust the Observebility tutorials doc Dec 20, 2023
@nataliasitko nataliasitko deleted the fix-linnks-20.12 branch December 20, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants