test: Increase moduletemplateinfolookup testcoverage #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
c-pius
reviewed
Feb 26, 2025
There was a problem hiding this comment.
Overall looks good! Just some hints for tests cases that should be easy to add and will get us close to 100%
With this one, I am actually not sure... If I understand the code correctly, this cannot happen because if those two things don't match, the filterTemplatesByChannel func won't return a template.
pkg/templatelookup/moduletemplateinfolookup/by_channel_strategy_test.go
Outdated
Show resolved
Hide resolved
pkg/templatelookup/moduletemplateinfolookup/by_channel_strategy_test.go
Outdated
Show resolved
Hide resolved
nesmabadr
force-pushed
the
increase_moduletemplateinfolookup_testcoverage
branch
from
b142c14 to
a329ba8
Compare
nesmabadr
force-pushed
the
increase_moduletemplateinfolookup_testcoverage
branch
from
34b6e82 to
a5555f7
Compare
c-pius
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Resolves #2202