Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(report): Remove the status for the package metrics report #11

Merged
merged 1 commit into from
Dec 7, 2023
Merged

chore(report): Remove the status for the package metrics report #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions coverage-metrics/bin/utils/package-metrics/compare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
from argparse import ArgumentParser
import json
from prettytable import PrettyTable
import os

COLOURS = {
"red": "\033[91m",
Expand Down Expand Up @@ -60,7 +59,6 @@ def highlight_delta(string, delta, is_new=False):

table = PrettyTable(("Package", "Efferent", "Afferent", "External"))

status = os.EX_OK
for pkg, pkg_metrics in target.items():
is_new = pkg not in base

Expand All @@ -73,7 +71,8 @@ def highlight_delta(string, delta, is_new=False):
external_label = " %+d" % delta_external if delta_external != 0 else ""

if not is_new and any(delta > 0 for delta in [delta_efferent, delta_afferent, delta_external]):
status = os.EX_DATAERR
# Notify that the metrics increased for some packages.
pass

table.add_row(
(pkg,
Expand All @@ -87,5 +86,4 @@ def highlight_delta(string, delta, is_new=False):
table.align["Afferent"] = "r"
table.align["External"] = "r"
print(table)

exit(status)
exit(0)